feat: create relationship import system by vtotalova · Pull Request #45 · ls1intum/memo

vtotalova · 2026-04-13T19:03:21Z

Description

Implements a bulk import system for competency relationships, allowing admins to create multiple relationships at once from a JSON or CSV file. Relationships can be referenced by competency ID or title, with an optional seed vote on import.

Type of Change

Related Issues

Fixes feat: create relationship import system #43

Changes Made

Client:
- Added RelationshipImportPage at /admin/import/relationships with file upload (drag-and-drop) and JSON paste modes
- Added importRelationshipsJson and importRelationshipsFile methods to adminApi
- Added RelationshipImportRow interface to types.ts; fixed CompetencyRelationship.relationshipType union to include UNRELATED
- Registered new route and added "Import Relationships" card to the Admin panel
Server:
- Added RelationshipImportRow DTO supporting originId/originTitle, destinationId/destinationTitle, and optional relationshipType
- Added bulkImportRelationships() to CompetencyRelationshipService with per-row validation, title-to-ID resolution, duplicate skipping, and optional vote seeding
- Added findByTitle() to CompetencyRepository
- Added POST /api/admin/relationships/import (JSON) and POST /api/admin/relationships/import/file (CSV/JSON) to AdminController with dynamic header-based CSV parsing
Database: No migrations required
Other: Added sample-data/relationships-sample.json and relationships-sample.csv for manual testing

Testing

Test Cases

Existing functionality still works
New functionality works as expected
Edge cases handled appropriately

Manual Testing

Tested in development environment
Tested with different user roles/permissions (if applicable)

Verified the following scenarios via the Import Relationships UI and the provided sample files:

ID-based rows — both competencies looked up by ID, relationship created
Title-based rows — both competencies resolved by exact title match
Mixed rows — one side by ID, other by title
With relationshipType — vote seeded on the corresponding counter, entropy recalculated
Without relationshipType — relationship created with zero votes
Duplicate pair — skipped and counted in skipped, not errors
Unknown title — per-row error returned in ImportResult.errors
Self-reference — per-row error returned
Invalid relationshipType — per-row error returned
CSV file upload — columns matched by header name (case-insensitive, order-independent)
JSON file upload — deserialized and processed identically to JSON paste
Admin-only access — endpoint returns 403 for non-admin users

Screenshots/Videos

Before

After

…mmary

…ication-flows

…sable component to use it on main page and while onboarding

Copilot

Pull request overview

Implements an admin-facing bulk import workflow for competency relationships (CSV/JSON), alongside a broader shift to Keycloak-backed authentication/authorization and a new admin panel surface for moderation and role management.

Changes:

Added admin UI pages for moderation, importing competencies/relationships, role management, and export placeholder.
Introduced Keycloak auth integration on the client (AuthProvider, protected/admin routes, axios bearer token injection).
Added server-side admin import endpoints + import DTOs/results, plus /api/auth/me, JWT resource server config, and user schema updates for Keycloak UUID subjects.

Reviewed changes

Copilot reviewed 49 out of 51 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/pages/SessionPage.tsx	Switches demo-user bootstrap to fetch current authenticated user.
src/pages/RolesPage.tsx	New admin UI to view users and toggle roles.
src/pages/RelationshipImportPage.tsx	New UI for relationship bulk import via file upload or JSON paste.
src/pages/OnboardingPage.tsx	Integrates auth state into onboarding flow; persists some fields in sessionStorage; adds privacy-policy link.
src/pages/ModerationPage.tsx	New admin UI for inline editing and deleting competencies/resources.
src/pages/ImportPage.tsx	New UI for competency bulk import via file upload or JSON paste.
src/pages/HomePage.tsx	Start button now navigates based on auth + onboarded status.
src/pages/ExportPage.tsx	New “Export” placeholder page in admin area.
src/pages/DashboardPage.tsx	Uses authenticated userId for stats instead of guest constant.
src/pages/AdminPage.tsx	New admin panel landing page with cards to admin tools.
src/lib/auth/keycloak.ts	Adds Keycloak client initialization (check-sso, PKCE, silent SSO).
src/lib/api/types.ts	Adds ImportResult + RelationshipImportRow; expands relationshipType union with UNRELATED; adds degree to Competency.
src/lib/api/session-helpers.ts	Adds `/api/auth/me` helper for retrieving current user.
src/lib/api/client.ts	Adds axios request interceptor to attach Bearer token and refresh token when needed.
src/lib/api/admin.ts	New admin API client for import endpoints (JSON + file).
src/index.css	Extends CSS custom properties for theme colors.
src/contexts/useAuth.ts	New hook for accessing AuthContext.
src/contexts/auth-context.ts	Defines AuthContextValue and creates AuthContext.
src/contexts/AuthContext.tsx	New AuthProvider that initializes Keycloak, syncs `/api/auth/me`, and exposes auth state/actions.
src/components/navbar.tsx	Shows sign-in/out + admin link based on auth/role; updates gradient class usage.
src/components/ProtectedRoute.tsx	New route guard requiring authentication (and handling domain denial).
src/components/AdminRoute.tsx	New route guard requiring ADMIN role.
src/App.tsx	Wraps app in AuthProvider; adds protected and admin route structure + new pages.
server/src/main/resources/db/migration/V9__update_users_for_keycloak_auth.sql	Alters users table for Keycloak subjects and adjusts one FK column length.
server/src/main/resources/application.yml	Configures OAuth2 resource server JWT, multipart limits, Flyway settings, and allowed email domain list.
server/src/main/java/de/tum/cit/memo/service/UserService.java	Adds find-or-create by Keycloak subject.
server/src/main/java/de/tum/cit/memo/service/CompetencyService.java	Adds bulk import logic for competencies with per-row validation/skip.
server/src/main/java/de/tum/cit/memo/service/CompetencyRelationshipService.java	Adds bulk relationship import with title/id resolution, duplicate skipping, and optional vote seeding.
server/src/main/java/de/tum/cit/memo/security/SecurityConfig.java	Switches API to JWT-authenticated resource server; restricts admin and delete routes.
server/src/main/java/de/tum/cit/memo/security/DbRoleJwtAuthenticationConverter.java	Maps authorities from DB role keyed by JWT subject.
server/src/main/java/de/tum/cit/memo/repository/CompetencyRepository.java	Adds `existsByTitle` and `findByTitle`.
server/src/main/java/de/tum/cit/memo/entity/User.java	Makes name/email nullable and expands id length to 36.
server/src/main/java/de/tum/cit/memo/dto/RelationshipImportRow.java	DTO for relationship import rows.
server/src/main/java/de/tum/cit/memo/dto/ImportResult.java	Record for import result summary.
server/src/main/java/de/tum/cit/memo/dto/CompetencyImportRow.java	DTO for competency import rows.
server/src/main/java/de/tum/cit/memo/controller/AuthController.java	Adds `/api/auth/me` to enforce domain allowlist + sync user record.
server/src/main/java/de/tum/cit/memo/controller/AdminController.java	Adds admin import endpoints for competencies and relationships; implements CSV/JSON parsing.
server/src/main/java/de/tum/cit/memo/config/MemoProperties.java	Adds `memo.allowed-email-domains` config binding.
server/src/main/java/de/tum/cit/memo/MemoApiApplication.java	Enables configuration properties scanning.
server/docker/keycloak/memo-realm.json	Updates Keycloak realm config (protocol mapper for email; SMTP config; removes seeded users).
server/docker-compose.yml	Adds Mailpit; configures Keycloak + API + DB containers; adjusts Keycloak issuer env.
server/build.gradle	Adds Spring OAuth2 resource server dependency.
sample-data/relationships-sample.json	Adds sample relationship import JSON.
sample-data/relationships-sample.csv	Adds sample relationship import CSV.
sample-data/competencies-sample.json	Adds sample competency import JSON.
sample-data/competencies-sample.csv	Adds sample competency import CSV.
public/silent-check-sso.html	Adds Keycloak silent SSO callback page.
postcss.config.mjs	Removed config file (repo retains postcss.config.js).
package-lock.json	Dependency lockfile updates.
auth-flow.svg	Adds auth flow diagram (SVG).
auth-flow.mmd	Adds auth flow diagram (Mermaid source).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ystem

github-actions · 2026-04-13T19:15:26Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

github-actions · 2026-04-13T19:51:22Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

github-actions · 2026-04-14T09:31:56Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

…control-rbac

…c' into feature/43-feat-create-relationship-import-system

github-actions · 2026-04-14T10:46:45Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

MaximilianAnzinger

Please have a look at the merge conflict

…ystem

github-actions · 2026-04-24T15:34:39Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

…ystem

github-actions · 2026-04-24T15:49:12Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

github-actions · 2026-04-26T15:29:40Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

github-actions · 2026-04-26T17:55:19Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

✅ No console statements found
⚠️ Found 'any' or 'unknown' types - consider using more specific types

markstockhausen and others added 30 commits February 3, 2026 02:22

style: change font and polish UI

650775a

style: update font weight

79e45a2

style: conform to Prettier formatting

430e1c2

Implement optimized Scheduling Service and Pipeline Logic

73a402b

style: update comments

8850cf6

Implement AI suggestions

fe676c3

Update Axios, Optimise scheduling pipeline

b199432

Optimise pipeline logic and clean up code

67d6e58

Optimise pipeline

60d7f66

Update logic for bidirectional relationship types

6251a3a

Streamline implementation

e683410

Conform to Prettier formatting

141bebd

Implement AI suggestions

64c4f20

Further AI suggestions

d863e77

Merge branch 'main' into feature/implement-scheduling-service

846fd3d

feat: add dashboard with contribution heatmap, badges, and session su…

7916901

…mmary

style: fix Prettier formatting

4b03244

Update heatmap

2190551

Conform to Prettier formatting

785d9fa

Fix security audit

2704820

feat: Add initial version of onboarding

32ccd39

fix onboarding flow

99f89e1

conform to Prettier formatting

4a8eeba

Update profile setup

49e98c2

add simple auth implementation

c4a25a2

Merge branch 'main' into feature/36-security-implement-secure-authent…

cf2faae

…ication-flows

Fix skip feature, update package-lock.json

513e8c4

Add milestone celebration toasts during mapping sessions

47042eb

Update screenshot on main page, extract CompetencyNetworkViz into reu…

23c8d8b

…sable component to use it on main page and while onboarding

implement auth

65c98b0

Copilot started reviewing on behalf of vtotalova April 13, 2026 19:03 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Merge branch 'main' into feature/43-feat-create-relationship-import-s…

73c6442

…ystem

github-actions Bot added enhancement New feature or request dependencies 📦 Dependency updates and removed client-application 🎨 Client-side/UI changes labels Apr 13, 2026

vtotalova changed the title ~~Feature/43 feat create relationship import system~~ feat: create relationship import system Apr 13, 2026

fix formating

b9a62db

fix npm packeges

69ecce9

vtotalova added 5 commits April 14, 2026 11:43

Merge branch 'main' into feature/40-feat-implement-role-based-access-…

246cf78

…control-rbac

fix npm packages

e55c739

integrate copilot feedback

95ab67e

Merge branch 'feature/40-feat-implement-role-based-access-control-rba…

285634e

…c' into feature/43-feat-create-relationship-import-system

implement copilot feedback

91f9c35

MaximilianAnzinger reviewed Apr 24, 2026

View reviewed changes

Merge branch 'main' into feature/43-feat-create-relationship-import-s…

74417d5

…ystem

github-actions Bot removed the dependencies 📦 Dependency updates label Apr 24, 2026

Merge branch 'main' into feature/43-feat-create-relationship-import-s…

bbdbc4f

…ystem

vtotalova requested a review from MaximilianAnzinger April 24, 2026 16:33

fix migrations

23d6d79

fix vuln

3b33ec4

github-actions Bot added the dependencies 📦 Dependency updates label Apr 26, 2026

Uh oh!

Conversation

vtotalova commented Apr 13, 2026

Description

Type of Change

Related Issues

Changes Made

Testing

Test Cases

Manual Testing

Screenshots/Videos

Before

After

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Apr 13, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Apr 14, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Apr 14, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

MaximilianAnzinger left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 24, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Apr 24, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Apr 26, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Apr 26, 2026

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants